Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update reva #3175

Merged
merged 2 commits into from
Feb 16, 2022
Merged

update reva #3175

merged 2 commits into from
Feb 16, 2022

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Feb 15, 2022

Updated reva to latest edge.
This includes the implementation for #2986

@C0rby C0rby self-assigned this Feb 15, 2022
@C0rby C0rby requested review from micbar, butonic and rhafer February 15, 2022 15:25
@ownclouders
Copy link
Contributor

ownclouders commented Feb 15, 2022 •
edited
Loading

💥 Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...

@rhafer
Copy link
Contributor

rhafer commented Feb 15, 2022

boom Acceptance test Web-Tests-ocis-smoke-ocis-storage-1 failed. Further test are cancelled...

@C0rby I think this should be fixed if you rebase to latest master

@C0rby
Copy link
Contributor Author

C0rby commented Feb 15, 2022

Thanks!

@sonarcloud
Copy link

sonarcloud bot commented Feb 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor

phil-davis commented Feb 16, 2022 •
edited
Loading

The JSON response to a "list spaces" request no longer includes the structure "owner - user - id". A space has users who have the "manager" role. There is not a single "owner" of a space.

I adjusted the failing test so that it looks for the "manager" role permission.

Note: the requirement of these sort of tests (existing tests, and the test that I adjusted) are rather brittle, because they specify the index "0", "1" etc where the permission/role appears in the array of user permissions/roles. That breaks if the permissions array is returned in a different order, which is not a good thing. We are thinking about how best to refactor that so that tests are less brittle see issue #3179

@phil-davis phil-davis mentioned this pull request Feb 16, 2022
Closed
@phil-davis phil-davis merged commit dd7a2f6 into master Feb 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-reva branch February 16, 2022 05:05
ownclouders pushed a commit that referenced this pull request Feb 16, 2022
@phil-davis
commit dd7a2f6
5ed308a 
Merge: 22385ba 8386d24
Author: Phil Davis <[email protected]>
Date:   Wed Feb 16 10:50:20 2022 +0545

    Merge pull request #3175 from owncloud/update-reva

    update reva
@C0rby
Copy link
Contributor Author

C0rby commented Feb 16, 2022 •
edited
Loading

Thanks @phil-davis for taking care. I wanted to take a look today but since you've already dealt with it we can just continue with the oCIS release. 👍 💪

@micbar micbar mentioned this pull request Feb 16, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@micbar micbar Awaiting requested review from micbar

@butonic butonic Awaiting requested review from butonic

@rhafer rhafer Awaiting requested review from rhafer

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@C0rby @ownclouders @rhafer @phil-davis